Topology2: Audio: add CTC to PTL cs42l43 path.#10825
Conversation
Include CTC component in PTL with cs42l43. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
Include CTC component in PTL with rt721. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
|
@bardliao pls check |
| DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,BT_PCM_ID=20,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\ | ||
| SDW_SPK_ENHANCED_PLAYBACK=false" | ||
|
|
||
| "cavs-sdw\;sof-ptl-cs42l43-agg-l3-cs35l56-l2-ctc\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_CTC_LINKS=2,\ |
There was a problem hiding this comment.
It's not easy for me to catch the change until I realize the deviation is brought by either "NUM_SDW_AMP_LINKS" or "NUM_SDW_AMP_CTC_LINKS" in use.
That also makes sense to me, but I remember NUM_SDW_AMP_LINKS has been referenced by some codes to get the number of speaker. Could you confirm that doesn't matter for the cases using NUM_SDW_AMP_CTC_LINKS?
There was a problem hiding this comment.
NUM_SDW_AMP_LINKS means how many SoundWire links do the amps connect to. For example, NUM_SDW_AMP_LINKS should be 2 if 4 amps connect to 2 SDW links. And NUM_SDW_AMP_LINKS should be 1 if 4 amps connect to 1 SDW link.
There was a problem hiding this comment.
I have updated the CTC conf files to use NUM_SDW_AMP_CTC_LINKS. This variable correctly scales the DAIs and channels (e.g., 2 links = 4 speakers/channels). NUM_SDW_AMP_LINKS is only used in topology files.
There was a problem hiding this comment.
@johnylin76 @bardliao resolved now for you ?
The change looks good to me. But I don't understand why can't we reuse NUM_SDW_AMP_LINKS and add CTC to a new SDW_AMP_PIPELINE_SRC type, like DAX, DTS? Please bear with me, as I don't know those processing.
There was a problem hiding this comment.
The CTC is not mutually exclusive with DAX or DTS. In fact, we have topologies that combine them, such as DAX + CTC and DTS + CTC.
If I understand the current design correctly, if we made CTC a SDW_AMP_PIPELINE_SRC type, we wouldn't be able to combine them easily because SDW_AMP_PIPELINE_SRC only allows selecting one type (e.g., we would have to create hybrid types like dax-ctc). Using NUM_SDW_AMP_CTC_LINKS allows us to enable CTC as an independent feature while still allowing the user to select the base pipeline source (DAX, DTS, or Generic) separately.
There was a problem hiding this comment.
That is correct. Some may have the combination of 1 CTC + 1 general postprocessing (e.g. DAX, DTS) so they should be treated in different ways. With that being said, I still feel we should respect to NUM_SDW_AMP_LINKS but that can be put to the next page.
Fix NUM_SDW_AMP_CTC_LINKS definitions in CTC related topologies. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
lyakh
changed the title
5 participants
Include CTC component in PTL with cs42l43.